alamb commented on code in PR #12043:
URL: https://github.com/apache/datafusion/pull/12043#discussion_r1720759782
##########
datafusion/functions-window/src/row_number.rs:
##########
@@ -31,8 +31,8 @@ use datafusion_expr::{Expr, PartitionEvaluator, Signature,
Volatility, WindowUDF
/// Create a [`WindowFunction`](Expr::WindowFunction) expression for
/// `row_number` user-defined window function.
-pub fn row_number(args: Vec<Expr>) -> Expr {
- Expr::WindowFunction(WindowFunction::new(row_number_udwf(), args))
+pub fn row_number() -> Expr {
Review Comment:
Note row_number() does not take an argument -- it was erroniously changed
here https://github.com/apache/datafusion/pull/12030 and it happens we didn't
have other tests for it
```sql
> select row_number() OVER ();
+-----------------------------------------------------------------------+
| ROW_NUMBER() ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING |
+-----------------------------------------------------------------------+
| 1 |
+-----------------------------------------------------------------------+
1 row(s) fetched.
Elapsed 0.042 seconds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
