notfilippo commented on code in PR #11978:
URL: https://github.com/apache/datafusion/pull/11978#discussion_r1719931672
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -195,6 +214,10 @@ impl ColumnarValue {
kernels::cast::cast_with_options(array, cast_type,
&cast_options)?,
)),
ColumnarValue::Scalar(scalar) => {
+ if scalar.data_type().logically_eq(cast_type) {
Review Comment:
Yes, I agree! The issue is that that function still returns a ColumnarValue
for physical execution, which would mean that the Cast, even when physical,
would lose the type information (and be a no-op) since it would result in a
ColumnarValue::ScalarValue(...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
