andygrove commented on code in PR #832:
URL: https://github.com/apache/datafusion-comet/pull/832#discussion_r1718747032
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -441,20 +459,20 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(COMET_SCHEMA_EVOLUTION_ENABLED_DEFAULT)
- val COMET_SPARK_TO_COLUMNAR_ENABLED: ConfigEntry[Boolean] =
+ val COMET_SPARK_TO_ARROW_ENABLED: ConfigEntry[Boolean] =
conf("spark.comet.sparkToColumnar.enabled")
Review Comment:
I don't have a strong feeling whether we should change the config key or
not. I think the description sufficiently explains what this does and I didn't
want to cause extra work for people who are already using these configs.
If others think we should change it then I am fine with that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
