viirya commented on code in PR #832:
URL: https://github.com/apache/datafusion-comet/pull/832#discussion_r1718508825
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -1131,12 +1133,39 @@ object CometSparkSessionExtensions extends Logging {
// operators can have a chance to be converted to columnar. Leaf operators
that output
// columnar batches, such as Spark's vectorized readers, will also be
converted to native
// comet batches.
- // TODO: consider converting other intermediate operators to columnar.
- op.isInstanceOf[LeafExecNode] &&
CometSparkToColumnarExec.isSchemaSupported(op.schema) &&
- COMET_SPARK_TO_COLUMNAR_ENABLED.get(conf) && {
+ if (CometSparkToColumnarExec.isSchemaSupported(op.schema)) {
+ op match {
+ // v1 scan
Review Comment:
```suggestion
// Convert Spark DS v1 scan to Arrow format
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
