andygrove commented on code in PR #832:
URL: https://github.com/apache/datafusion-comet/pull/832#discussion_r1718379212
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1974,27 +1974,30 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
test("get_struct_field") {
- withSQLConf(
- CometConf.COMET_SPARK_TO_COLUMNAR_ENABLED.key -> "true",
- CometConf.COMET_SPARK_TO_COLUMNAR_SUPPORTED_OPERATOR_LIST.key ->
"FileSourceScan") {
- withTempPath { dir =>
- var df = spark
- .range(5)
- // Add both a null struct and null inner value
- .select(
- when(
- col("id") > 1,
- struct(
- when(col("id") > 2, col("id")).alias("id"),
- when(col("id") > 2, struct(when(col("id") > 3,
col("id")).alias("id")))
- .as("nested2")))
- .alias("nested1"))
-
- df.write.parquet(dir.toString())
-
- df = spark.read.parquet(dir.toString())
- checkSparkAnswerAndOperator(df.select("nested1.id"))
- checkSparkAnswerAndOperator(df.select("nested1.nested2.id"))
+ Seq("", "parquet").foreach { v1List =>
Review Comment:
I added this line so that we test with both v1 and v2 sources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
