emilk commented on code in PR #24322:
URL: https://github.com/apache/datafusion/pull/24322#discussion_r3775227257
##########
benchmarks/src/nlj.rs:
##########
@@ -226,7 +226,7 @@ impl RunOpt {
}
Err(e) => {
return Err(DataFusionError::Context(
- "NLJ benchmark Q{query_id} failed with
error:".to_string(),
+ format!("NLJ benchmark Q{query_id} failed with
error:"),
Review Comment:
It was silently printing the literal text `Q{query_id}`. The lint found a
second one too, in `parquet_advanced_index.rs`.
-- Claude
##########
datafusion/core/tests/memory_limit/memory_limit_validation/sort_mem_validation.rs:
##########
@@ -161,9 +161,7 @@ async fn sort_with_mem_limit_2_cols_1() {
.await;
}
-// TODO: Query fails, fix it
-// Issue: https://github.com/apache/datafusion/issues/14143
-#[ignore]
+#[ignore = "Query fails, see
https://github.com/apache/datafusion/issues/14143";]
Review Comment:
Restored both the `TODO` and `Issue` comments; the `#[ignore]` now just
carries a short reason pointing at them.
-- Claude
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -9624,6 +9628,10 @@ mod tests {
}
#[test]
+ #[expect(
+ clippy::lossy_float_literal,
Review Comment:
Reverted the `lossy_float_literal` lint. Also reverted `float_cmp_const` and
`fallible_impl_from` per your other messages.
-- Claude
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -2996,7 +2992,7 @@ mod tests {
),
(
"307445734561825860m",
- Duration::from_secs(307445734561825860 * 60),
+ Duration::from_hours(5124095576030431),
Review Comment:
Agreed, changed to `Duration::from_mins(307445734561825860)` so the
constructor matches the `m` suffix. Same value, and it reads as the test
intends.
That form trips `duration_suboptimal_units` itself (it wants `from_hours`),
so the test now carries an `#[expect]` explaining that each `Duration`
deliberately uses the unit from the string it parses.
-- Claude
##########
datafusion/datasource-parquet/src/opener/mod.rs:
##########
@@ -676,7 +676,7 @@ impl ParquetMorselPlanner {
impl MorselPlanner for ParquetMorselPlanner {
fn plan(self: Box<Self>) -> Result<Option<MorselPlan>> {
- if let ParquetOpenState::Done = self.state {
+ if matches!(self.state, ParquetOpenState::Done) {
Review Comment:
Not here, unfortunately: `ParquetOpenState` does not implement `PartialEq`
and cannot easily, since its variants hold boxed futures and readers. Left as
`matches!`.
-- Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
