emilk commented on code in PR #24322:
URL: https://github.com/apache/datafusion/pull/24322#discussion_r3775066253
##########
datafusion/core/tests/memory_limit/memory_limit_validation/sort_mem_validation.rs:
##########
@@ -161,9 +161,7 @@ async fn sort_with_mem_limit_2_cols_1() {
.await;
}
-// TODO: Query fails, fix it
-// Issue: https://github.com/apache/datafusion/issues/14143
-#[ignore]
+#[ignore = "Query fails, see
https://github.com/apache/datafusion/issues/14143";]
Review Comment:
keep TODO
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -9624,6 +9628,10 @@ mod tests {
}
#[test]
+ #[expect(
+ clippy::lossy_float_literal,
Review Comment:
revert this lint
##########
datafusion/datasource-parquet/src/opener/mod.rs:
##########
@@ -676,7 +676,7 @@ impl ParquetMorselPlanner {
impl MorselPlanner for ParquetMorselPlanner {
fn plan(self: Box<Self>) -> Result<Option<MorselPlan>> {
- if let ParquetOpenState::Done = self.state {
+ if matches!(self.state, ParquetOpenState::Done) {
Review Comment:
could be == ?
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -2996,7 +2992,7 @@ mod tests {
),
(
"307445734561825860m",
- Duration::from_secs(307445734561825860 * 60),
+ Duration::from_hours(5124095576030431),
Review Comment:
this is worse. We should use from_mins here to match the `m"` suffix on the
string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
