alamb opened a new issue, #24312: URL: https://github.com/apache/datafusion/issues/24312
### Is your feature request related to a problem or challenge? - Part of https://github.com/apache/datafusion/issues/21706 - Follow up to https://github.com/apache/datafusion/issues/21937 Most benchmark suites have been ported to the new SQL based benchmark framework (`benchmark_runner`, see https://github.com/apache/datafusion/pull/21707 and follow on PRs). However, the old rust-based `dfbench` runner (`benchmarks/src/bin/dfbench.rs` and the per-suite modules in `benchmarks/src/`) still exists in parallel. Maintaining two benchmark implementations means duplicated code and the risk that the two runners drift apart and report different results for the same suite. ### Describe the solution you'd like Once `bench.sh` has been migrated to the new framework (https://github.com/apache/datafusion/issues/24311), remove the old `dfbench` runner and the now-unused suite code, keeping `dfbench` only for benchmarks that cannot be expressed as SQL (if any remain). ### Describe alternatives you've considered Keep both runners indefinitely. ### Additional context @Omega359 mentioned in https://github.com/apache/datafusion/issues/21937#issuecomment-5196560905 that they planned to file/work on this cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
