alamb opened a new issue, #24311: URL: https://github.com/apache/datafusion/issues/24311
### Is your feature request related to a problem or challenge? - Part of https://github.com/apache/datafusion/issues/21706 - Follow up to https://github.com/apache/datafusion/issues/21937 #21707 and follow on PRs (most recently https://github.com/apache/datafusion/pull/23772) added a SQL based benchmark framework with a `benchmark_runner` binary that can run the ported suites (tpch, clickbench, h2o, imdb, tpcds, etc) either directly or via criterion. However, `benchmarks/bench.sh` still runs the benchmarks through the old `dfbench` binary, so the two benchmarking paths coexist and results from `bench.sh` do not benefit from the new framework. ### Describe the solution you'd like Update `bench.sh` to run benchmarks via the new SQL benchmark framework / `benchmark_runner` for the suites that have been ported, as described in https://github.com/apache/datafusion/issues/21937#issuecomment-4353678551. This likely also includes updating result comparison (`compare` / `compare_detail`, potentially using [critcmp](https://github.com/BurntSushi/critcmp) for criterion-based runs). ### Describe alternatives you've considered Leave `bench.sh` on `dfbench` indefinitely (this means maintaining two benchmark implementations — see the follow up ticket about removing `dfbench`). ### Additional context @Omega359 mentioned in https://github.com/apache/datafusion/issues/21937#issuecomment-5196560905 that they planned to file/work on this cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
