tohuya6 commented on code in PR #23783:
URL: https://github.com/apache/datafusion/pull/23783#discussion_r3683587436
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -1352,6 +1377,56 @@ mod tests {
}
}
+ /// End-to-end coverage for `Duration` group keys: a `Duration` column
stays
+ /// on the `GroupValuesColumn` fast path, deduplicates equal durations
+ /// (including nulls), and round-trips with its `Duration` output type
+ /// preserved (not the bare `i64` native). The four units share one
builder,
+ /// so a single unit exercises the dispatcher; the fuzz above covers
routing
+ /// for every unit.
+ #[test]
+ fn test_group_values_column_duration() {
+ use arrow::datatypes::TimeUnit;
+
+ let schema = Arc::new(Schema::new(vec![Field::new(
Review Comment:
appreciate your review kosiew
updated test to use Duration(Microsecond), Int64, it should be more direct
now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
