github-actions[bot] commented on PR #23783: URL: https://github.com/apache/datafusion/pull/23783#issuecomment-5102218005
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-plan v54.1.0 (current) Built [ 46.425s] (current) Parsing datafusion-physical-plan v54.1.0 (current) Parsed [ 0.148s] (current) Building datafusion-physical-plan v54.1.0 (baseline) Built [ 41.637s] (baseline) Parsing datafusion-physical-plan v54.1.0 (baseline) Parsed [ 0.148s] (baseline) Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.637s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/inherent_method_missing.ron Failed in: WindowAggExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/windows/window_agg_exec.rs:367 AsyncFuncExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/async_func.rs:290 GroupOrderingPartial::reset, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/aggregates/order/partial.rs:191 EmptyExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/empty.rs:215 ExplainExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/explain.rs:217 CrossJoinExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/joins/cross_join.rs:485 HashJoinExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/joins/hash_join/exec.rs:1857 NestedLoopJoinExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/joins/nested_loop_join.rs:810 AggregateExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/aggregates/mod.rs:2349 SymmetricHashJoinExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/joins/symmetric_hash_join.rs:749 GroupOrderingFull::reset, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/aggregates/order/full.rs:119 GlobalLimitExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/limit.rs:274 LocalLimitExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/limit.rs:498 PlaceholderRowExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/placeholder_row.rs:216 AnalyzeExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/analyze.rs:348 RepartitionExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/repartition/mod.rs:1785 SortExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/sorts/sort.rs:1606 SortPreservingMergeExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/sorts/sort_preserving_merge.rs:479 UnionExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/union.rs:495 InterleaveExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/union.rs:741 UnnestExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/unnest.rs:346 GroupOrdering::reset, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/14a066cea32bc8ad22b51dd42877d798ed1e0a3d/datafusion/physical-plan/src/aggregates/order/mod.rs:102 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 90.828s] datafusion-physical-plan Building datafusion-sqllogictest v54.1.0 (current) Built [ 216.843s] (current) Parsing datafusion-sqllogictest v54.1.0 (current) Parsed [ 0.023s] (current) Building datafusion-sqllogictest v54.1.0 (baseline) Built [ 193.861s] (baseline) Parsing datafusion-sqllogictest v54.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sqllogictest v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.083s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 413.642s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
