djanand commented on code in PR #1866: URL: https://github.com/apache/datafusion-ballista/pull/1866#discussion_r3414480430
########## python/Cargo.lock: ########## @@ -642,6 +642,7 @@ dependencies = [ "futures", "http", "insta", + "itertools", Review Comment: @martin-g - The `python/` workspace depends on `ballista-core` and `ballista-scheduler` via path deps, and those crates recently gained `itertools` and `tower-http` as direct dependencies. The lock file just reflects that. i.e no new deps were introduced by this PR. The CI run without lock change is [here](https://github.com/apache/datafusion-ballista/actions/runs/27530389236/job/81366868681) Did a bit of digging and `pyproject.toml` has `locked = true` under [tool.maturin], which passes --locked to cargo, requiring python/Cargo.lock to be fully up to date and committed. Let me know if I'm missing anything -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
