djanand commented on PR #1866:
URL:
https://github.com/apache/datafusion-ballista/pull/1866#issuecomment-4705560544
> oes this mean that if someone changes `__name__` attribute, this would
still break ?
Both DataFrame.__name__ and the annotation string "DataFrame" would change
together if DataFusion renames the class, so they stay in sync. But if
they hardcoded "DataFrame" and the class was renamed to e.g.
`DataFrameV2`, the annotation would update but the hardcoded string wouldn't,
causing silent breakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
