martin-g commented on code in PR #1866:
URL:
https://github.com/apache/datafusion-ballista/pull/1866#discussion_r3413724811
##########
python/python/ballista/extension.py:
##########
@@ -112,12 +111,11 @@ def method_wrapper(*args, **kwargs):
for base_name, base_value in bases[0].__dict__.items():
#
Review Comment:
```suggestion
```
Let's remove the whole comment. Not just the middle of it
##########
python/python/ballista/extension.py:
##########
@@ -112,12 +111,11 @@ def method_wrapper(*args, **kwargs):
for base_name, base_value in bases[0].__dict__.items():
#
- # could we not use 'DataFrame' as a string here?
#
Review Comment:
```suggestion
```
##########
python/Cargo.lock:
##########
@@ -642,6 +642,7 @@ dependencies = [
"futures",
"http",
"insta",
+ "itertools",
Review Comment:
Why are those dependencies added ?
They do not look related to the changes above
##########
python/python/ballista/extension.py:
##########
@@ -72,12 +72,11 @@ def method_wrapper(*args, **kwargs):
for base_name, base_value in bases[0].__dict__.items():
#
- # TODO: could we not use 'DataFrame' as a string here?
#
Review Comment:
```suggestion
```
##########
python/python/ballista/extension.py:
##########
@@ -72,12 +72,11 @@ def method_wrapper(*args, **kwargs):
for base_name, base_value in bases[0].__dict__.items():
#
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
