theirix commented on code in PR #22244:
URL: https://github.com/apache/datafusion/pull/22244#discussion_r3300195052
##########
datafusion/functions/src/string/concat_ws.rs:
##########
@@ -934,4 +915,116 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn concat_ws_binary_scalars() -> Result<()> {
+ let c0 =
ColumnarValue::Scalar(ScalarValue::Binary(Some(b"|".to_vec())));
+ let c1 =
ColumnarValue::Scalar(ScalarValue::Binary(Some(b"aa".to_vec())));
+ let c2 = ColumnarValue::Scalar(ScalarValue::Binary(None));
+ let c3 =
ColumnarValue::Scalar(ScalarValue::Binary(Some(b"cc".to_vec())));
+
+ let arg_fields = vec![
+ Field::new("a", Binary, true).into(),
+ Field::new("a", Binary, true).into(),
+ Field::new("a", Binary, true).into(),
+ Field::new("a", Binary, true).into(),
+ ];
+ let args = ScalarFunctionArgs {
+ args: vec![c0, c1, c2, c3],
+ arg_fields,
+ number_rows: 1,
+ return_field: Field::new("f", Binary, true).into(),
+ config_options: Arc::new(ConfigOptions::default()),
+ };
+ let result = ConcatWsFunc::new().invoke_with_args(args)?;
+ match result {
+ ColumnarValue::Scalar(ScalarValue::Binary(Some(v))) => {
+ assert_eq!(v, b"aa|cc");
+ }
+ other => panic!("Expected Binary scalar, got {other:?}"),
+ }
+
+ Ok(())
+ }
+
+ #[test]
+ fn concat_ws_binary_arrays() -> Result<()> {
+ let c0 =
ColumnarValue::Scalar(ScalarValue::Binary(Some(b",".to_vec())));
+ let c1 = ColumnarValue::Array(Arc::new(BinaryArray::from_vec(vec![
+ b"foo".as_ref(),
+ b"bar",
+ b"baz",
+ ])));
+ let c2 =
ColumnarValue::Array(Arc::new(LargeBinaryArray::from_opt_vec(vec![
+ Some(b"x".as_ref()),
+ None,
+ Some(b"z"),
+ ])));
+
+ let arg_fields = vec![
+ Field::new("a", Binary, true).into(),
+ Field::new("a", Binary, true).into(),
+ Field::new("a", LargeBinary, true).into(),
+ ];
+ let args = ScalarFunctionArgs {
+ args: vec![c0, c1, c2],
+ arg_fields,
+ number_rows: 3,
+ return_field: Field::new("f", LargeBinary, true).into(),
+ config_options: Arc::new(ConfigOptions::default()),
+ };
+
+ let result = ConcatWsFunc::new().invoke_with_args(args)?;
+ let expected = Arc::new(LargeBinaryArray::from_opt_vec(vec![
+ Some(b"foo,x".as_ref()),
+ Some(b"bar"),
+ Some(b"baz,z"),
+ ])) as ArrayRef;
+ match &result {
+ ColumnarValue::Array(array) => assert_eq!(&expected, array),
+ _ => panic!("Expected array result"),
+ }
+
+ Ok(())
+ }
+ //
+ // #[test]
Review Comment:
Just merged into one test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
