theirix commented on code in PR #22244:
URL: https://github.com/apache/datafusion/pull/22244#discussion_r3300189922
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -112,6 +113,16 @@ impl ScalarUDFImpl for ConcatFunc {
let arg_types: Vec<DataType> = args.iter().map(|c|
c.data_type()).collect();
let return_datatype = deduce_return_type(&arg_types);
+ let with_binary = arg_types.iter().any(|dt| dt.is_binary());
+ let with_string = arg_types.iter().any(|dt| dt.is_string());
+
+ if with_binary && with_string {
+ return plan_err!(
Review Comment:
Good idea, changed. It also required using the same coercion rules for Spark
concat, which was missing before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
