Re: [PR] fix: skip negative scale checks for creating decimals [datafusion-comet]

[via GitHub]

kazuyukitanimura commented on PR #723:
URL: https://github.com/apache/datafusion-comet/pull/723#issuecomment-2253289076

   SF=100
   
   ## getDecimal(Long)
   ### Before
   ![Screenshot 2024-07-26 at 11 39 30 
AM](https://github.com/user-attachments/assets/b01b7efb-828d-410a-a2c0-d70b4513368b)
   ### After
   ![Screenshot 2024-07-26 at 11 39 51 
AM](https://github.com/user-attachments/assets/82099c6f-00b9-4ac6-af2d-8d85406586a5)
   ## getDecimal(128)
   ### Before
   ![Screenshot 2024-07-26 at 11 40 13 
AM](https://github.com/user-attachments/assets/9a01709c-770c-4203-b81c-a26025b90ecd)
   ### After
   ![Screenshot 2024-07-26 at 11 40 29 
AM](https://github.com/user-attachments/assets/37068f5a-b8bd-4e92-8b3b-31a2caaa8058)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org