kazuyukitanimura commented on code in PR #723:
URL: https://github.com/apache/datafusion-comet/pull/723#discussion_r1690804474


##########
common/src/main/java/org/apache/comet/vector/CometDictionary.java:
##########
@@ -30,7 +30,7 @@ public class CometDictionary implements AutoCloseable {
   private final int numValues;
 
   /** Decoded dictionary values. We only need to copy values for decimal type. 
*/
-  private ByteArrayWrapper[] binaries;
+  private volatile ByteArrayWrapper[] binaries;

Review Comment:
   This is not directly related but forgot to add based on 
https://github.com/apache/datafusion-comet/pull/705#discussion_r1688697138



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to