adriangb commented on code in PR #21807:
URL: https://github.com/apache/datafusion/pull/21807#discussion_r3141012287
##########
datafusion/physical-expr/Cargo.toml:
##########
@@ -55,6 +55,7 @@ indexmap = { workspace = true }
itertools = { workspace = true, features = ["use_std"] }
parking_lot = { workspace = true }
petgraph = "0.8.3"
+rand = { workspace = true }
Review Comment:
Right now the ids are also random (generated from a mashup of arc pointer
address, process id, etc.). So in that sense it's no better or worse. But I do
agree something deterministically generated from context would be better.
The only alternative that occurs to me is a process level atomic. Not sure
if that might cause some locking, etc. Do you have any other suggestions?
Lastly: we can always change this. As long as there is no API contract on
what this number is going to be we could replace it at any point if it becomes
a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
