jayshrivastava commented on code in PR #21807:
URL: https://github.com/apache/datafusion/pull/21807#discussion_r3140821733
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -346,6 +375,75 @@ impl DynamicFilterPhysicalExpr {
write!(f, " ]")
}
+
+ /// Generate a new expression id for this filter.
+ fn new_expression_id() -> u64 {
+ random::<u64>()
+ }
+
+ /// Return the filter's original children (before any remapping).
+ ///
+ /// **Warning:** intended only for `datafusion-proto` (de)serialization.
+ /// Not a stable API.
+ pub fn original_children(&self) -> &[Arc<dyn PhysicalExpr>] {
+ &self.children
+ }
+
+ /// Return the filter's remapped children, if any have been set via
+ /// [`PhysicalExpr::with_new_children`].
+ ///
+ /// **Warning:** intended only for `datafusion-proto` (de)serialization.
+ /// Not a stable API.
+ pub fn remapped_children(&self) -> Option<&[Arc<dyn PhysicalExpr>]> {
+ self.remapped_children.as_deref()
+ }
+
+ /// Rebuild a `DynamicFilterPhysicalExpr` from its stored parts. Used by
+ /// proto deserialization to preserve `expression_id` across a roundtrip
+ /// rather than minting a fresh one.
+ ///
+ /// **Warning:** intended only for `datafusion-proto` (de)serialization.
+ /// Not a stable API.
Review Comment:
The shared state discussion seems promising! I'm hoping it will be an easy
migration. I imagine that we would end up storing all `Inner`s in the
`TaskContext` instead of in the actual `DynamicFilterPhysicalExpr` and looking
up the `Inner`s via the `expression_id`. It's still an ongoing discussion
though so I can't be sure how the migration will look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
