adriangb commented on code in PR #21807:
URL: https://github.com/apache/datafusion/pull/21807#discussion_r3140079824


##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -88,6 +92,148 @@ struct Inner {
     is_complete: bool,
 }
 
+/// An atomic snapshot of a [`DynamicFilterPhysicalExpr`] used to reconstruct 
the expression during
+/// serialization / deserialization.
+pub struct DynamicFilterSnapshot {

Review Comment:
   Thank you. I opened https://github.com/apache/datafusion/issues/21835 to 
track the idea of splitting up proto ser to avoid leaking internal state all 
over



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to