timsaucer commented on code in PR #21240:
URL: https://github.com/apache/datafusion/pull/21240#discussion_r3065564984
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -3792,7 +3894,11 @@ struct DataEncoderTuple {
pub blob: Vec<u8>,
}
-pub struct DefaultPhysicalProtoConverter;
+#[derive(Default)]
+pub struct DefaultPhysicalProtoConverter {
+ scalar_subquery_results: RefCell<Option<ScalarSubqueryResults>>,
Review Comment:
This feels like a bit of an anti-pattern. I'm going to need a bit of time to
dive into what's going on here, but hopefully will get to it either this
afternoon or maybe Sunday evening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
