milenkovicm commented on PR #21240: URL: https://github.com/apache/datafusion/pull/21240#issuecomment-4231439621
> ## Protobuf changes > I am not sure about the changes to the protobuf serialization / registries / etc (e.g. to take TaskContext rather than FunctionRegistry); I think @timsaucer and @milenkovicm are more clued in than I am in this area > > Perhaps you could break those changes (to protobuf serialization traits) into a separate PR so it is easier for them to review / evaluate the scope of the changes > we should have replaced `FunctionRegistry` with `TaskContext`, at the moment its a bit of mix and match, it makes sense to align all methods on task context, perhaps update guide should be upgraded -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
