connec commented on PR #11533: URL: https://github.com/apache/datafusion/pull/11533#issuecomment-2241268032
The issue is caused by the line endings in the `newlines_in_values.csv` file being converted to `CRLF` on windows. While either line ending is accepted as a CSV record terminator by default, newlines in values are not normalised at all. This means that the value returned from the query on Windows includes `CRLF` rather than `LF`. Since newlines in the `.slt` file itself *are* normalised, this then leads to the diff. For now, I've added a `.gitattributes` entry to checkout the `newlines_in_values.csv` file with `LF` line endings always, which resolves the problem on my windows machine at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
