alamb commented on PR #11533:
URL: https://github.com/apache/datafusion/pull/11533#issuecomment-2240180169
> There's the new clippy issue around having too many arguments for
`CsvExec::new`, which I can either fix with a new `Options` struct of some
kind, or suppress and fix in a follow-up.
I think we should suppress the clippy error for now in this PR and we can
file a ticket to improve things as a follow on PR
I would personally suggest a builder pattern like
```rust
let csv_exec = CsvExec::builder()
.with_has_header(true)
.with_newlines_in_values(true)
...
.build()?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
