connec commented on code in PR #11533:
URL: https://github.com/apache/datafusion/pull/11533#discussion_r1684123766
##########
datafusion/common/src/config.rs:
##########
@@ -1665,6 +1670,14 @@ impl CsvOptions {
self
}
+ /// Set true to ensure that newlines in (quoted) values are supported.
Review Comment:
The phrasing was a bit awkward initially as I was thinking of the flag as
"ensuring support", rather than directly "supporting", since newlines in values
are already supported if the file is below the
`datafusion.optimizer.repartition_file_min_size`.
I'm not sure if it's worth conveying that detail through these docs, or else
to document this as providing support and treat the fact that newlines in
values will "just work" for smaller files as an implementation detail that
might change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
