LiaCastaneda commented on issue #20899: URL: https://github.com/apache/datafusion/issues/20899#issuecomment-4074039226
> Do not fully understand how this will help map_expressions implementation to recompute them. Each implementation could have its own PlanStruct::recompute_properties and call it (it's not necessary to make it as the trait method). I think it just gives users a uniform way to trigger property recomputation on any ExecutionPlan without knowing the concrete type, and avoids the need to downcast to specific nodes if we ever need to call it externally. I think you are right though, this could be a follow-up rather than a prerequisite. I wasn't aware that `properties()` is already part of the `ExecutionPlan` trait, which makes all of this more standard than I initially thought. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
