LiaCastaneda commented on issue #20899: URL: https://github.com/apache/datafusion/issues/20899#issuecomment-4064043544
> Implementing two methods with the similar semantic seems hard to maintain. What if we inject recompute properties behavior to the closure return type with a lightweight structure? mmm i think one limitation would be that the Recompute path assumes each `ExecutionPlan` implementor knows how to rebuild their own plan properties. For native nodes this might be fine since `compute_properties` is called internally, but for people implementing a custom `ExecutionPlan`, there is no standard public API to say "recompute my properties given my current state." They would have to call either their own ::new() constructor (which may do more than just recompute properties) or manually construct `PlanProperties` . Maybe it makes semse to make recompute_properties part of the executionPlan trait (probably optional to implement)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
