killzoner commented on code in PR #1429: URL: https://github.com/apache/datafusion-ballista/pull/1429#discussion_r2746892031
########## .github/actions/setup-builder/action.yaml: ########## @@ -18,6 +18,14 @@ name: Prepare Rust Builder description: 'Prepare Rust Build Environment' inputs: + cmake: + description: 'install cmake' Review Comment: `snmalloc-rs` does, and since we run lint with `--all-features`, it's needed We might just remove snmalloc since it's not really maintained for now, donated to microsoft root project but no active publication to crates.io since then https://github.com/microsoft/snmalloc/tree/main/snmalloc-rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
