killzoner commented on code in PR #1429: URL: https://github.com/apache/datafusion-ballista/pull/1429#discussion_r2745322153
########## benchmarks/src/bin/tpch.rs: ########## @@ -67,14 +67,17 @@ use structopt::StructOpt; #[cfg(test)] use tokio::task::JoinHandle; -#[cfg(feature = "snmalloc")] +#[cfg(all(feature = "snmalloc", not(feature = "mimalloc")))] #[global_allocator] static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc; -#[cfg(feature = "mimalloc")] +#[cfg(all(feature = "mimalloc", not(feature = "snmalloc")))] #[global_allocator] static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc; +#[cfg(all(feature = "snmalloc", feature = "mimalloc", not(feature = "lint")))] Review Comment: This one is a trick to allow linter to pass while enabling error reporting to the user. Can remove if too tricky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
