parthchandra commented on PR #549: URL: https://github.com/apache/datafusion-comet/pull/549#issuecomment-2161208622
> The input is a slice of `u8`, so it has no particular alignment, and we are trying to turn it into a slice of `u32` using `from_raw_parts`. What I meant was that we expect the source buffer to be aligned on a word boundary. Subsequently, all offsets applied to the starting address are at least a multiple of size of word so every input should be aligned. It appears at least one of my assertions above is not true and it might be useful to know why. Unaligned access has two potential problems - on some platforms, it may cause a SIGBUS and, more importantly, access to an unaligned address is usually much slower. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
