andygrove commented on code in PR #549:
URL: https://github.com/apache/datafusion-comet/pull/549#discussion_r1633786050
##########
core/src/parquet/read/values.rs:
##########
@@ -455,23 +455,21 @@ macro_rules! make_int_variant_impl {
while num - i >= 32 {
unsafe {
- let in_slice = std::slice::from_raw_parts(in_ptr, 32);
Review Comment:
This is unsafe because there is no guarantee that the buffer is properly
aligned for u32 typw (in_ptr is defined earier as `let mut in_ptr =
&src_data[src_offset..] as *const [u8] as *const u8 as *const u32;`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
