alamb commented on issue #10602: URL: https://github.com/apache/datafusion/issues/10602#issuecomment-2142453740
@appletreeisyellow and I just had a chat about what to do about this ticket. It is great that we seem to have found a workaround there are at least two potential issues we see with the workaround: 1. It is non obvious and likely would not be obvious to other future users 2. It may have performance issues, as @Abdullahsab3 notes in https://github.com/apache/datafusion/issues/10602#issuecomment-2140461400 We think it would be great to improve DataFusion so future users (both of InfluxDB and other systems) who use `date_bin` have fast queries and are not confused. # Ideal Behavior We think the ideal user experience would be as @tustvold [suggests](https://github.com/apache/datafusion/issues/10602#issuecomment-2126783877) for `date_bin` to be timezone aware and just "do the right thing and bin dates respecting the timezone of the timestamp". While this might be different than what postgres does, the underlying treatment if timestamps is already different, so I don't think we need to be quirk for quirk compatible. # Proposal Thus we propose @appletreeisyellow will try and complete her prototype work to make `date_bin` do the intuitive thing with timestamps with timezones It is likely we can't devote a large amount of time to this project, so if the implementation is taking too long we may have to abandon this effort or go with a less optimal route (e.g. a function to strip off timezones like Postgres) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
