Abdullahsab3 commented on issue #10602: URL: https://github.com/apache/datafusion/issues/10602#issuecomment-2140461400
Very nice! Thanks for verifying @appletreeisyellow. I was able to do some minimal validations today on our systems and it seems indeed to be binning correctly. Happy to see this as an alternative to what I was doing as a fix for this issue My main concerns with the use of `to_char` are: - Performance: Not super familiar with Datafusion internals, but I assume `to_char` will parse the given timestamp in the provided format, and return a string, which will be coerced to a (localtime) timestamp. - Probably not a problem and I am just overthinking it, but I wonder whether `%F %X` will always produce the correct localtime. My concern is mostly the %F part -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
