jonahgao commented on code in PR #10615:
URL: https://github.com/apache/datafusion/pull/10615#discussion_r1610123495
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1278,6 +1279,40 @@ pub(crate) fn from_substrait_literal(lit: &Literal) ->
Result<ScalarValue> {
s,
)
}
+ Some(LiteralType::List(l)) => {
+ let elements = l
+ .values
+ .iter()
+ .map(|el| from_substrait_literal(el))
+ .collect::<Result<Vec<_>>>()?;
+ let element_type = elements[0].data_type();
Review Comment:
Should we check if elements are empty and report an error? The literal input
might come from systems other than DataFusion, and they might not be properly
implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
