Blizzara commented on code in PR #10615:
URL: https://github.com/apache/datafusion/pull/10615#discussion_r1609714005
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1138,7 +1139,7 @@ fn from_substrait_type(dt: &substrait::proto::Type) ->
Result<DataType> {
from_substrait_type(list.r#type.as_ref().ok_or_else(|| {
substrait_datafusion_err!("List type must have inner
type")
})?)?;
- let field = Arc::new(Field::new("list_item", inner_type,
true));
+ let field = Arc::new(Field::new_list_field(inner_type, true));
Review Comment:
this is a breaking change in the sense that the new field name is just
"item" - to align with Arrow default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
