jonahgao commented on code in PR #10615:
URL: https://github.com/apache/datafusion/pull/10615#discussion_r1610111225
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1361,7 +1396,24 @@ fn from_substrait_null(null_type: &Type) ->
Result<ScalarValue> {
d.precision as u8,
d.scale as i8,
)),
- _ => not_impl_err!("Unsupported Substrait type: {kind:?}"),
+ r#type::Kind::List(l) => {
+ let field = Field::new_list_field(
+ from_substrait_type(l.r#type.clone().unwrap().as_ref())?,
+ true,
+ );
+ match l.type_variation_reference {
+ DEFAULT_CONTAINER_TYPE_REF =>
Ok(ScalarValue::List(Arc::new(
+ GenericListArray::new_null(field.into(), 1),
Review Comment:
I think it is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
