kazuyukitanimura commented on code in PR #436:
URL: https://github.com/apache/datafusion-comet/pull/436#discussion_r1603760627
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -249,7 +249,7 @@ abstract class CometTestBase
var dfSpark: Dataset[Row] = null
withSQLConf(
CometConf.COMET_ENABLED.key -> "false",
- "spark.sql.extendedExplainProvider" -> "") {
+ "spark.sql.extendedExplainProviders" -> "") {
Review Comment:
Thanks,
> nit: could we make this literal as a constant
I added the constant in a shim because it is defined in Spark 4.0
> do we really need to pass this param with blank value?
Yes, the caller of this method (`CometExpressionSuite`) defines a value and
need to overwrite.
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -259,7 +259,7 @@ abstract class CometTestBase
dfSpark.queryExecution.explainString(ExtendedMode),
dfComet.queryExecution.explainString(ExtendedMode))
if (supportsExtendedExplainInfo(dfSpark.queryExecution)) {
- assert(diff.contains(expectedInfo))
+ assert(expectedInfo.exists(s => diff.contains(s)))
Review Comment:
Thanks
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
