advancedxy commented on code in PR #436:
URL: https://github.com/apache/datafusion-comet/pull/436#discussion_r1603360782
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -249,7 +249,7 @@ abstract class CometTestBase
var dfSpark: Dataset[Row] = null
withSQLConf(
CometConf.COMET_ENABLED.key -> "false",
- "spark.sql.extendedExplainProvider" -> "") {
+ "spark.sql.extendedExplainProviders" -> "") {
Review Comment:
nit: could we make this literal as a constant filed in this CometTestBase
such as how we define `org.apache.spark.sql.CometTestBase#shuffleManager`?
It could be reused in CometExpressionSuite.scala as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
