viirya commented on code in PR #436:
URL: https://github.com/apache/datafusion-comet/pull/436#discussion_r1603425800
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1399,7 +1399,7 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
CometConf.COMET_EXEC_ENABLED.key -> "true",
CometConf.COMET_SHUFFLE_ENFORCE_MODE_ENABLED.key -> "true",
CometConf.COMET_EXEC_ALL_OPERATOR_ENABLED.key -> "true",
- "spark.sql.extendedExplainProvider" ->
"org.apache.comet.ExtendedExplainInfo") {
Review Comment:
Hmm, but we don't run tests against Spark 4.0 currently, right?
Although it is okay for this PR as it is to fix incorrect config name, it
sounds a little strange to have a test that can pass no matter what.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
