wiedld commented on code in PR #10224: URL: https://github.com/apache/datafusion/pull/10224#discussion_r1580096720
########## datafusion/sqllogictest/test_files/copy.slt: ########## @@ -283,11 +283,73 @@ OPTIONS ( 'format.statistics_enabled::col2' none, 'format.max_statistics_size' 123, 'format.bloom_filter_fpp' 0.001, -'format.bloom_filter_ndv' 100 +'format.bloom_filter_ndv' 100, +'format.metadata::key' 'value' ) ---- 2 +# valid vs invalid metadata + +# accepts map with a single entry +statement ok +COPY source_table +TO 'test_files/scratch/copy/table_with_metadata/' +STORED AS PARQUET +OPTIONS ( + 'format.metadata::key' 'value' +) + +# accepts multiple entries (on different keys) +statement ok +COPY source_table +TO 'test_files/scratch/copy/table_with_metadata/' +STORED AS PARQUET +OPTIONS ( + 'format.metadata::key1' '', + 'format.metadata::key2' 'value', + 'format.metadata::key3' 'value with spaces', + 'format.metadata::key4' 'value with special chars :: :' +) + +# accepts multiple entries with the same key (will overwrite) Review Comment: This overwriting is a common feature to all of the config `OPTIONS(...)`. If we want to change, then I recommend a followup ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
