alamb commented on code in PR #10224: URL: https://github.com/apache/datafusion/pull/10224#discussion_r1579878064
########## datafusion/sqllogictest/test_files/copy.slt: ########## @@ -283,11 +283,69 @@ OPTIONS ( 'format.statistics_enabled::col2' none, 'format.max_statistics_size' 123, 'format.bloom_filter_fpp' 0.001, -'format.bloom_filter_ndv' 100 +'format.bloom_filter_ndv' 100, +'format.metadata' 'foo:bar baz' ) ---- 2 +# valid vs invalid metadata + +# accepts empty map +statement ok +COPY source_table +TO 'test_files/scratch/copy/table_with_metadata/' +STORED AS PARQUET +OPTIONS ( +'format.metadata' '' +) + +# accepts map with a single entry +statement ok +COPY source_table +TO 'test_files/scratch/copy/table_with_metadata/' +STORED AS PARQUET +OPTIONS ( +'format.metadata' 'key:value' +) + +# accepts map with multiple entries +statement ok +COPY source_table +TO 'test_files/scratch/copy/table_with_metadata/' +STORED AS PARQUET +OPTIONS ( +'format.metadata' 'key1:value1 key2:value2' Review Comment: this is quite and I missed it the first time around -- nice eyes @devinjdangelo . @wiedld could you please add documentation to the `TableParquetOptions` that documents this behavior? Specifically, I would be interested to know "what if you want to store metadata values that have spaces in them" (`key1:my value with spaces`)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
