On 06/08/2016 03:07 AM, Junio C Hamano wrote:
I am having a hard time guessing what prompted you to sort the
output, i.e. what problem you were trying to solve. It cannot be
because addresses on a list (e.g. Cc:) could come out in an
indeterministic order, because the address that a test expects to be
the first (c...@example.com in the above example) may not appear as
the first one, but in the textual output it _is_ shown differently
from the remainder (i.e. even if you sort, from "Cc:
c...@example.com," it is clear it was the first one output for Cc: and
diferent from "A <aut...@example.com>".
Actually we had issues when trying to refactor send-email's email
parsing loop [1]. Email addresses in output file `commandeline1` in
tests weren't sorted the same way as the reference file it was compared
to. E.g.:
!nob...@example.com!
!aut...@example.com!
!o...@example.com!
!t...@example.com!
I agree replacing test_cmp with test_cmp_noorder is pointless, I will
fix it and re-roll.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
