Attention is currently required from: jolly, laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email )
Change subject: firmware: replace libosmocore fsm timers ...................................................................... Patch Set 5: (2 comments) Patchset: PS4: > I would prefer if the host code would simply get a jiffies variable + a timer > updating it. […] no idea what is easier to test on the host since it has very little in common with interrupt driven uarts and their failure modes which was the reason why the octsim had everything except the one thing that mattered which was error handling and it has not been used by anone during the past 6 years but oh well there is a jiffies emulation now so it keeps building. File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481/comment/504bdec0_6b979db2?usp=email : PS4, Line 271: ip->uart->wtime_deadline = timeout_ms ? (jiffies + timeout_ms) + 1 : 0; > You are reading 'jiffies', which is incremented by interrupt. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd Gerrit-Change-Number: 42481 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: jolly <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 26 Mar 2026 12:39:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <[email protected]> Comment-In-Reply-To: laforge <[email protected]>
