Attention is currently required from: Hoernchen. jolly has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email )
Change subject: firmware: replace libosmocore fsm timers ...................................................................... Patch Set 4: (1 comment) File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481/comment/86b5131d_325313a9?usp=email : PS4, Line 271: ip->uart->wtime_deadline = timeout_ms ? (jiffies + timeout_ms) + 1 : 0; You are reading 'jiffies', which is incremented by interrupt. I think that this 64 bit read is not atomic, so it may glitch, if an SysTick interrupt fires between reading lower and upper part of that jiffies value. But this is quite unlikely. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd Gerrit-Change-Number: 42481 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: jolly <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 08:51:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
