Jenkins Builder has posted comments on this change by Hoernchen. ( 
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email )

Change subject: firmware: replace libosmocore fsm timers
......................................................................


Patch Set 1:

(1 comment)

File ccid_common/cuart.c:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481/comment/1657d7d2_2b14bbde?usp=email
 :
PS1, Line 87:   if (deadline && jiffies >= deadline) {
Comparing jiffies is almost always wrong; prefer time_after, time_before and 
friends



--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd
Gerrit-Change-Number: 42481
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 24 Mar 2026 15:12:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to