> Jody Garnett ha scritto: >> I have made the change proposal here: >> - http://docs.codehaus.org/display/GEOTOOLS/Clean+up+Generics+from+DataStore >> I am going to complete the SimpleFeatureCollection patch today for trunk. > > The idea looks good, there is probably something about the language in > the proposal that confuses me.
Yeah I was sleepy; let me do an editing run. > > For example, what is the section "Introduce SimpleFeatureSource to 2.6.x" > about? The change to introduce SimpleFeatureSource, SimpleFeatureStore was actually pretty small. The change to introduce SimpleFeatureCollection was not. They are two seperate patches. If you like we can consider the SimpleFeatureSource patch for 2.6.x; it has 50% of the benifit in terms of cleaning up the example code. > It's a big change, better to avoid doing it on trunk and besides you say > above and in the jira that the patch is for trunk (trunk only I guess). > > And you cite FeatureAccess... which is actually not there. > > About the renderer using simple features, it's really about performance, > I can see if I can use Feature but the current implementation may be bad > performance wise (accessing attributes through it is more costly afaik). It is not really an issue until we get more generic feature collections; there is a small number of places where SimpleFeature was assumed in the rendering code. With respect to performance I think that if SimpleFeatures are passed in the performance will be the same? > To sum up, maybe clean up a little the proposal. I feel good about the > change, I should just get some time to actually try to apply the patch > (will try to do that soon) Thanks Andrea; I would like the feedback of yourself and Micheal if possible. I will try and submit a few more patches of this nature; but nothing so scary. Jody ------------------------------------------------------------------------------ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
