Peter Humphrey <pe...@prh.myzen.co.uk> writes:
On Wednesday 15 January 2025 11:50:02 Greenwich Mean Time I
wrote:
https://bugs.gentoo.org/948143
That bug now has a patch, which proposes to move from
sci-misc/boinc-7.24.1-r1
to -r2. The scale of the changes proposed seems to me too big
for such
a minor
revision bump, but more than that, it has several diffs against
separate files,
and I'm not /au-fait/ enough with patching to know what to do
with
them all.
Would anyone here like to have a go at it?
Well, as the person who submitted that patch, i'd like to comment
on this.
As some background:
* i've contributed a number of patches, such as to
gentoo-pipewire-launcher:
https://bugs.gentoo.org/907891
* i currently have a new ebuild for the main repo awaiting
additional review from Sam, who hasn't been able to get to it
because he's constantly snowed under:
https://bugs.gentoo.org/908431
* i maintain a few ebuilds in my overlay:
https://sr.ht/~flexibeast/gentoo-overlay/
More generally, i'm a regular contributor to the Gentoo wiki;
cf. https://wiki.gentoo.org/wiki/User:Flexibeast#Gentoo_wiki .
So:
* The move from -r1 to -r2 is required because a revision change
is required when there any changes to an ebuild, including to
Gentoo-provided files, that don't come from upstream. This in
turn requires a new ebuild file, which makes up a significant
amount of the patch.
* There are small changes to the boinc.conf and boinc.init files,
which i consider to be the minimum required to address the
suggestions that were made. Specifically:
* The changes to boinc.conf remove the custom PID file variable,
replacing it with the standard $pidfile variable, and adds the
standard $retry variable.
* The changes to boinc.init add default values for $pidvalue and
$retry in env_check(); change start() to use $pidfile instead of
the custom variable; move the call to env_check() into
stop_pre(); and change the stop() function to use the $pidfile
and $retry variables.
(Further to Michael Orlitzky's comment on the bug, it looks to me
that the default stop() function doesn't use the $retry variable,
so we need to provide a stop() function that does. i'll note this
on the bug report shortly.)
i find your post here quite odd, discouraging, and an example of
why i'm increasingly disinclined to devote so much time to
volunteer ICT work, - that i would instead be better served by
increasing my other volunteer work in other areas, where my
experience is of people's gratitude rather than of
entitlement. Rather than being appreciative of someone
volunteering to take on the work, and rather than asking
clarifying questions on the bug itself about what you don't
understand, you've written a post on a public list effectively
dismissing my work, assuming that it's fundamentally wrong. Okay
then.
Alexis.
