On 07/25/2017 04:05 AM, Michał Górny wrote: > > Here's the current draft: > https://wiki.gentoo.org/wiki/User:MGorny/GLEP:Git >
It's mostly fine, but there are two changes I disagree with: > When doing one or more changes that require a revision bump, bump the > revision in the commit including the first change. Split the changes > into multiple logical commits without further revision bumps — since > they are going to be pushed in a single push, the user will not be > exposed to interim state. We shouldn't play games in the repo and hope that everything works out if we wait to push until just the right time. We're not going to run out of numbers -- it's simpler and more correct to do a new revision with each commit. > Gentoo developers are still frequently using Gentoo-Bug tag, > sometimes followed by Gentoo-Bug-URL. Using both simultaneously is > meaningless (they are redundant), and using the former has no > advantages over using the classic #nnnnnn form in the summary or the > body. There are two main advantages over having the bug number in the summary. Space is at a premium in the summary, as Tobias pointed out, and the Gentoo-Bug: whatever format is trivially machine-readable, whereas sticking it somewhere else is less so. And just a reminder -- Gokturk worked to get a lot of this stuff into the devmanual, e.g. https://devmanual.gentoo.org/ebuild-maintenance/index.html Some of that is important, like the warning not to use "bug #x" in the body of the commit message.
