On Thu, 23 Mar 2017 12:36:24 -0400
Michael Orlitzky <m...@gentoo.org> wrote:
> On 03/23/2017 09:36 AM, Alexis Ballier wrote:
> >>
> >> No, the argument is about "we want to clean up the tree from
> >> abusive hacks".
> >
> > This is yours. Mike's answer is merely asking for proper
> > justification and doesn't seem to have had an answer yet.
> >
>
> The PMS[0] says
>
> Ebuilds must not access [FILESDIR] in global scope.
>
> But, for example, autoconf-2.69-r2.ebuild does,
>
> if [[ -z ${__EBLITS__} && -n ${FILESDIR} ]] ; then
> source "${FILESDIR}"/eblits/main.eblit || die
> fi
>
> in global scope.
>
Continuing to be the devil's advocate, it seems adding '&& -d
${FILESDIR}' to that if would fix the issue too. At least with all
currently approved EAPIs.
About the part you quote, please see:
https://gitweb.gentoo.org/proj/pms.git/commit/?id=22a0ce7c0fe649572956f60d13e1003ced401689
This is arguably a backwards-breaking change in PMS that appeared after
the last EAPI was approved, so I definitely understand the need for a
better explanation here. Prior to that change, the only rule was that
ebuilds must not assume the directory exists except in src_* phases.
Alexis.
